search

NASA-IMPACT / veda-docs

Documentation for the VEDA Project
https://nasa-impact.github.io/veda-docs
Apache License 2.0
7 stars 7 forks source link

Update tutorials notebooks for urls and minor fixes #160

Closed maxrjones closed 3 months ago

maxrjones commented 3 months ago

This PR updates the tutorials notebooks with openveda.cloud URLS. It also adds .pre-commit-config.yaml for linting.

https://github.com/NASA-IMPACT/pangeo-notebook-veda-image/pull/27 along with bumping the image is required for stac_ipyleaflet to run. There's still an error 'message': 'Error caught with collection', 'error': KeyError('item_assets') after those fixes, I think I'll need a pointer on how to debug that.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 3 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-160/ on branch gh-pages at 2024-08-19 21:30 UTC

smohiudd commented 3 months ago

@maxrjones I'm only seeing the openveda.cloud update in the zonal statistic notebook. The other notebooks were just rerun/minor updates?

smohiudd commented 3 months ago

Where are you seeing 'message': 'Error caught with collection', 'error': KeyError('item_assets')?

maxrjones commented 3 months ago

@maxrjones I'm only seeing the openveda.cloud update in the zonal statistic notebook. The other notebooks were just rerun/minor updates?

Yeah, I ran through them all and made minor fixes while updating the URLs. I updated the PR title to be more descriptive.

maxrjones commented 3 months ago

Where are you seeing 'message': 'Error caught with collection', 'error': KeyError('item_assets')?

That was happening when running https://github.com/NASA-IMPACT/veda-docs/blob/main/notebooks/tutorials/stac_ipyleaflet.ipynb with the image from this PR - https://github.com/NASA-IMPACT/pangeo-notebook-veda-image/pull/27.

maxrjones commented 3 months ago

Where are you seeing 'message': 'Error caught with collection', 'error': KeyError('item_assets')?

That was happening when running main/notebooks/tutorials/stac_ipyleaflet.ipynb with the image from this PR - NASA-IMPACT/pangeo-notebook-veda-image#27.

I think it would be best to address this in a separate PR.

anayeaye commented 3 months ago

Where are you seeing 'message': 'Error caught with collection', 'error': KeyError('item_assets')?

That was happening when running https://github.com/NASA-IMPACT/veda-docs/blob/main/notebooks/tutorials/stac_ipyleaflet.ipynb with the image from this PR - NASA-IMPACT/pangeo-notebook-veda-image#27.

I think maybe this needs to be fixed in stac_ipyleaflet https://github.com/MAAP-Project/stac_ipyleaflet/issues/130. I drafted an issue and maybe we can open a PR (it looks like a tiny change) for it eventually but maybe we should move forward with the other tutorial notebooks? @maxrjones @smohiudd

maxrjones commented 3 months ago

Where are you seeing 'message': 'Error caught with collection', 'error': KeyError('item_assets')?

That was happening when running main/notebooks/tutorials/stac_ipyleaflet.ipynb with the image from this PR - NASA-IMPACT/pangeo-notebook-veda-image#27.

I think maybe this needs to be fixed in stac_ipyleaflet MAAP-Project/stac_ipyleaflet#130. I drafted an issue and maybe we can open a PR (it looks like a tiny change) for it eventually but maybe we should move forward with the other tutorial notebooks? @maxrjones @smohiudd

Thanks for opening that issue! 💯 on moving forward with the other notebooks