search

NASA-IMPACT / veda-docs

Documentation for the VEDA Project
https://nasa-impact.github.io/veda-docs
Apache License 2.0
7 stars 7 forks source link

Add notebooks showing how to set up STAC objects #63

Closed jsignell closed 1 year ago

jsignell commented 1 year ago

Not sure if we want to reference these yet from the table of contents but moving them over to docs in the interest of consolidation

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jsignell commented 1 year ago

The notebooks on how to create and validate STAC metadata are great and will be very helpful for our users. Nice that they include the VEDA-specific fields.

A small change: Instead of including a sample GeoTIFF with this repo, we can perhaps just create a dummy COG with random data from code. Just grab the rasterio.Dataset.profile from the sample file and store it in code, perhaps.

Yep sounds good! I'll make that change.

NetCDF to COG conversion is definitely something to include in our docs, but not with this code, please. Let us rather include a nice example that uses rio-xarray. There should be one ready soon from the CMIP6 conversion.

Yeah it was much less clear how that notebook should work. If CMIP6 is a better example I am all for it.

So, could we please skip the NetCDF to COG conversion for now and just publish the STAC notebooks?

:+1:

We should probably link to them from the other docs on Catalog Ingestion, too.

Exactly! Ok I'll make those changes.

@j08lue or @ividito if we are ready to publish these notebooks what should be the call to action at the end? I was thinking open a PR on veda-data, but are we ready to make that repo public?

jsignell commented 1 year ago

I moved the new-cog notebook to its own branch in case we ever want to pick that work back up: jsignell/to-cog

j08lue commented 1 year ago

@j08lue or @ividito if we are ready to publish these notebooks what should be the call to action at the end? I was thinking open a PR on veda-data, but are we ready to make that repo public?

Yes, call to open a PR sounds right.

It looks to me like veda-data has been populated with all the relevant data, including the ingest issue template, from veda-data-pipelines. I just added a docs link to the README as well. So, to me, this can go public and become our official place to open ingest request tickets. @ividito, do you agree?

ividito commented 1 year ago

It looks to me like veda-data has been populated with all the relevant data, including the ingest issue template, from veda-data-pipelines. I just added a docs link to the README as well. So, to me, this can go public and become our official place to open ingest request tickets. @ividito, do you agree?

Yes, there's still some ongoing work to do but I think that repo will be where we want to collect new ingestion requests.

jsignell commented 1 year ago

Great! I'll just update the links on the veda-data side to reflect the mild reorg.

j08lue commented 1 year ago

Thanks for being so accepting of my "mild reorg", @jsignell. 😄 And for fixing it up.