search

NASA-IMPACT / veda-docs

Documentation for the VEDA Project
https://nasa-impact.github.io/veda-docs
Apache License 2.0
7 stars 7 forks source link

Feat/add mapping fires 2 #79

Closed abarciauskas-bgse closed 1 year ago

abarciauskas-bgse commented 1 year ago

This PR renames the wfs notebook and adds it to the TOC

@mccabete how does this look to you? You can check it out via the preview: https://nasa-impact.github.io/veda-docs/pr-preview/pr-79/notebooks/tutorials/mapping_fires.html

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 1 year ago

PR Preview Action v1.4.4 :---: :rocket: Deployed preview to https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-79/ on branch gh-pages at 2023-06-27 12:52 UTC

j08lue commented 1 year ago

Kindly asking @jsignell to review in my place.

mccabete commented 1 year ago

@abarciauskas-bgse this looks fine. There are a few changes that I think got lost in the file restructuring, but I can add them either here or after the merge.

mccabete commented 1 year ago

Added those changes to #80

jsignell commented 1 year ago

This looks broadly good! I think some things just got a little lost in the merges. I am fixing a typo and the binder link now and will push to this PR.

EDIT: I also changed the notebook name to use dashes rather than underscores to match the rest of the notebooks.

jsignell commented 1 year ago

Ok I just read through and re-executed the notebook to make double sure that Tess's changes made it in. I am going to merge when this is green, but just shout if something is missing :)

mccabete commented 1 year ago

Thanks Julia!

From: Julia Signell @.> Sent: Tuesday, June 27, 2023 8:50 AM To: NASA-IMPACT/veda-docs @.> Cc: Mccabe, Tempest @.>; Mention @.> Subject: Re: [NASA-IMPACT/veda-docs] Feat/add mapping fires 2 (PR #79)

Ok I just read through and re-executed the notebook to make double sure that Tess's changes made it in. I am going to merge when this is green, but just shout if something is missing :)

— Reply to this email directly, view it on GitHubhttps://github.com/NASA-IMPACT/veda-docs/pull/79#issuecomment-1609438994, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFCH6FZHXL456EIW5OVTGT3XNLJIDANCNFSM6AAAAAAZQ26WOI. You are receiving this because you were mentioned.Message ID: @.***>