Various cleanup on EA breakout feature branch

sandrahoang686 commented 2 weeks ago

Description of Changes

Fixed to have changes from https://github.com/NASA-IMPACT/veda-ui/pull/1231/files# which I accidentally removed when resolving conflicts in main feature branch
Remove onClick from LinkProperties
- When something is a link, it doesn't need an onClick event... The onClick event should be placed on the Card Component instead of link props
LinkProperties should not be required for the card component. Only when the card re-routes would it need the linkProperties. For example, cards on the dataset selector modal dont re-route and we shouldn't have to pass in linkProps
Remove try/catch around aoi area/point selection logic and into local state with useEffect

Note

Built v5.9.1-ea.0 off of these changes Update: Bulit v5.9.1-ea.1 has been built

Validation / Testing

Please make sure Dataset Layer Selection modal and E&A works as expected
Please make sure all cards in the dashboard are working as expected
- Make sure external cards link externally and have the external badge
- Make sure internal cards link internally correctly
- Make sure Dataset Layer Selection modal selects cards as expected

NextJs Preview with updated version: https://github.com/developmentseed/next-veda-ui/pull/4

netlify[bot] commented 2 weeks ago

Deploy Preview for veda-ui ready!

Name	Link
Latest commit	1ab1a3f0b58b934104901833411dcf342ca2140d
Latest deploy log	https://app.netlify.com/sites/veda-ui/deploys/6733b520caf0bf0008f52a9d
Deploy Preview	https://deploy-preview-1251--veda-ui.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sandrahoang686 commented 1 week ago

@dzole0311 I had to resolve a good amount of conflicts in the original Feature branch 902-ea-breakout and had missed some things which I then fixed alongside this PR. Particularly the code related to your external link hotfix (look at description). If you could check that I didn't miss anything though? Also, if there is anything in the main feature branch PR that you think needs to be cleaned up more, please feel free to add to this PR with those fixes. 🙏🏼

sandrahoang686 commented 1 week ago

LinkProperties are sprinkled in many places prop drilled quite deep, also the work around to support instances since they use the card component is just not ideal, we should probably update their code to pass in linkProps.. but I think we should spend more time looking at the navigation more holistically sometime in the future...

aboydnw commented 1 week ago

I also did some manual testing and couldn't find any issues with this pr/preview link. looks good to me ✅

NASA-IMPACT / veda-ui