search

NASA-LIS / LISF

Land Information System Framework
Apache License 2.0
116 stars 154 forks source link

ISRIC soil texture assigns wrong index value for water in LDT #1406

Closed dmocko closed 1 year ago

dmocko commented 1 year ago

When choosing ISRIC soil textures in LDT, an incorrect index value will be assigned to water points.

The LDT ISRIC reader re-maps the soil textures from the source ISRIC datasets onto the STATSGO soil texture classification.

However, ISRIC assigns water points an index value of 13, while this value should be 14 for the STATSGO soil texture classification.

ISRIC_water-points-issue_1 ISRIC_water-points-issue_2 ISRIC_water-points-issue_3

Although this is a bug, it shouldn't greatly affect past simulations that used the ISRIC soil textures, as the affected points are very likely to be "water" points in the landcover classifications as well. Still, users should check to ensure that this is true for their own individual past domains.

This bug revealed itself when running the MMF groundwater scheme in Noah-MP, which relies on soil textures even for water points.

Many thanks to @TimLahmers for identifying this issue.

TimLahmers commented 1 year ago

Thanks for submitting this @dmocko Please let us know when the PR to fix the bug is added. I will update my MMF branches and retest the code with this new fix when it is ready. That should be the final test needed before I submit the MMF PR.

cmclaug2 commented 1 year ago

Resolved by #1407, @TimLahmers