Remove format=None and intersect=covers for SDSS SIAP

NASA-NAVO / navo-workshop

Tutorial notebooks for how to use PyVO to access NASA and other data in Python.

https://NASA-NAVO.github.io/navo-workshop

BSD 3-Clause "New" or "Revised" License

41 stars 27 forks source link

Remove format=None and intersect=covers for SDSS SIAP #150

Closed stargaser closed 11 months ago

stargaser commented 11 months ago

Remove the format=None from SDSS SIAP searches
Slightly update KNOWN_ISSUES since format=None is no longer needed
Remove idiosyncratic intersect='covers' from first SDSS image search

Fixes #38

bsipocz commented 11 months ago

I suppose there was a genuine test failure with this notebook, namely something with the format

https://github.com/NASA-NAVO/navo-workshop/actions/runs/7214917787/job/19658931215#step:5:563

I'll have a look whether changing the minimal pyvo version in the oldest version run will resolve it.

bsipocz commented 11 months ago

Ahh, the format=None default has been added in v1.4.1, so I suppose we infact require that as a minimum now, or I could just update the oldest version run to agree with the check env file that Dave has already updated to 1.4.2