BUG: remove deprecated astropy usage: ``show_in_notebook``

NASA-NAVO / navo-workshop

Tutorial notebooks for how to use PyVO to access NASA and other data in Python.

https://NASA-NAVO.github.io/navo-workshop

BSD 3-Clause "New" or "Revised" License

41 stars 27 forks source link

BUG: remove deprecated astropy usage: ``show_in_notebook`` #176

Closed bsipocz closed 1 week ago

bsipocz commented 1 month ago

Not sure which one to recommend, I would go as far as we should use firefly?

WARNING: AstropyDeprecationWarning: show_in_notebook() is deprecated as of 6.1 and to create
         interactive tables it is recommended to use dedicated tools like:
         - https://github.com/bloomberg/ipydatagrid
         - https://docs.bokeh.org/en/latest/docs/user_guide/interaction/widgets.html#datatable
         - https://dash.plotly.com/datatable [warnings]

bsipocz commented 1 month ago

or ditch Tables and go all the way pandas. or manually enforce non-ellipsed table prints with manual scroller. I mean it's a pity that this functionality got removed.

bsipocz commented 2 weeks ago

OK, so this now produces a traceback as the backend has changed in astropy. Fix is easy for avoiding the traceback, but may need some testing if it indeed does what we want.

https://github.com/astropy/astropy/pull/17268

bsipocz commented 1 week ago

This has now been fixed with #179