search

NASA-NAVO / servicemon

1 stars 6 forks source link

Add mongodb writer. #36

Closed JohnGood closed 3 years ago

JohnGood commented 4 years ago

The mongo_writer.py file is the only change.

JohnGood commented 3 years ago

Both changes have been made.

tomdonaldson commented 3 years ago

I jumped to conclusions last week when I thought Travis was responsible for the CI errors in your pull request. It looks like we still have a few credits left where they're run CI for servicemon. I'll need to switch over to github actions soon though.

Anyway, the two issues are definitely fixable:

  1. A broken regression test: At servicemon/tests/test_plugin_support.py:39 the assertion fails because the count there needs to be incremented to account for your plugin which is automatically discovered.
  2. There are a few ticky tack violations of the codestyle check.

Assuming you've set up your dev environment with pip install -e ., and installed tox, you can run the regression tests locally with tox -e test or pytest, and can run the codestyle checks locally with tox -e codestyle.

@JohnGood I'm still seeing these CI issues. Not sure if they were intended to be addressed yet.