search

NASA-Openscapes / common

Common modules/tutorials/resources for NASA DAACs
0 stars 0 forks source link

Common practice: don't merge your own pull requests #16

Open jules32 opened 3 years ago

jules32 commented 3 years ago

Hi everyone,

In our GitHub Clinic last week @cpkrehbiel brought up a practice they have that people can't merge their own pull requests. I've been looking into GitHub settings for this, but only found this stackoverflow post from 2014.

For folks that already do this, how do you do it, just by practice or are there GitHub settings?

I was thinking that instating reviewing settings would be a good way. Any thoughts? Thanks

jules32 commented 3 years ago

Today Luis set this up as a Rule within our GitHub repo:

Settings > Branches > Branch protection rules > wrote "main" and selected first rule about not letting merge without PR.

Note: we're all admin so can override this too, but wanted to set this up as we get into the rhythm of reviewing