search

NASA-Openscapes / corn

Base image for the NASA-Openscapes Jupyterhub
MIT License
4 stars 5 forks source link

Merge recent changes from dev and VSCode installation into main #34

Closed ateucher closed 3 weeks ago

ateucher commented 4 months ago

This takes the work that @betolink had done in the dev branch (which is currently the image used in the hub) and recent work merged into main from #32, #33, etc

ateucher commented 4 months ago

@betolink this mostly looks good except that VSCode can't find the main Jupyter kernel (Running BYOI with openscapes/python:693163b), only opendap.

It is there:

(notebook) jovyan@jupyter-ateucher:~$ jupyter kernelspec list
Available kernels:
  opendap    /srv/conda/envs/notebook/share/jupyter/kernels/opendap
  python3    /srv/conda/envs/notebook/share/jupyter/kernels/python3

but VSCode doesn't see it

image.

I'm trying to track down why, but if you have any tips I'm happy to hear them!

ateucher commented 1 month ago

@betolink I'm just coming back to this, would be good to get the image updated. I see you're thinking about it too (https://github.com/NASA-Openscapes/corn/issues/35#issuecomment-2339238011)

I updated the environment again, I don't know how important the pinned versions are on some libraries (e.g., conda-lock, netcdf==1.6.5 in opendap), and should we update python (it's currently pinned to 3.10)?

ateucher commented 1 month ago

Also - VSCode seems to be behaving better now, the notebook environment seems to be default, and opendap is an option:

image

And the opendap kernel is also available:

image

The extensions are installed and working as they should

betolink commented 3 weeks ago

Sorry for the super delayed time to check this, I'm merging it and I think we can address the VSCode integration as a separate issue. @ateucher I think we should include the same con-lock on actions that CryoCloud has so we don't have to do it ourselves. And another thing we might want to take a look at is how can we use something like dependabot to update our packages and open PRs, I haven't looked in a while if there is a way to integrate it with Conda environments.

ateucher commented 3 weeks ago

Thanks @betolink. I think the vscode integration is now not bad, though some real-world user testing will tell us for sure.

same con-lock on actions that CryoCloud has so we don't have to do it ourselves.

I like that idea!