Discipline LDD workflow page is missing new discipline LDDs added to config

NASA-PDS / PLAID

APPS PDS Label Assistant for Interactive Design (PLAID). See an overview of the software on YouTube. https://www.youtube.com/watch?v=WCo8erW_rL8

https://plaid.jpl.nasa.gov

Other

9 stars 0 forks source link

Discipline LDD workflow page is missing new discipline LDDs added to config #21

Closed jordanpadams closed 3 years ago

jordanpadams commented 3 years ago

Per #4, some LDDs are missing from web page. Update to include those.

voxparcxls commented 3 years ago

Latest LDDs added to the version 1.F.

Missing dictionary, Ring_Moon_Systems:rings, is added through PDS Common

Disciplines Added --

First Header
img:Imaging
geom:Geometry
cart:Cartography
disp:Display_Settings
msn:Mission_Information
img_surface:Surface_Imaging
msn_surface:Surface_Mission_Information
nucspec:NucSpec_Observation_Properties
rings:Ring_Moon_Systems

Disciplines in process of adding --

First Header
sp:Spectral_Characteristics
speclib:Spectral_Library_Product
msss_cam_mh:MSSS_Camera_Mini_Header
proc:Processing_Information
survey:Survey

jordanpadams commented 3 years ago

thanks @voxparcxls . i'm assuming you are documenting how to update this as well?

voxparcxls commented 3 years ago

@jordanpadams Yes, it is will be part of the IM upgrade procedures

voxparcxls commented 3 years ago

@jordanpadams sp:Spectral_Characteristics included in the Discipline Dictionaries. Will be including the remaining disciplines and testing locally before opening PR for #21

voxparcxls commented 3 years ago

1.F.0.0 PDS4 LDDs are included. 5(**) of the dictionaries are not passing their elements to the xml build when selected

Thats a bug I'm trying to locate and fix for #21

I think I will rap it up in a few more days.

Disciplines Added --

Dictionaries
img:Imaging
geom:Geometry
cart:Cartography
disp:Display_Settings
msn:Mission_Information
img_surface:Surface_Imaging
msn_surface:Surface_Mission_Information
nucspec:NucSpec_Observation_Properties
rings:Ring_Moon_Systems
** sp:Spectral_Characteristics
** speclib:Spectral_Library_Product
** msss_cam_mh:MSSS_Camera_Mini_Header
** proc:Processing_Information
** survey:Survey

Screen Shot 2021-05-12 at 12 54 30 PM

voxparcxls commented 3 years ago

The full list of LDDs are now active and have selection enabled.

Disciplines Added --

Dictionaries
img:Imaging
geom:Geometry
cart:Cartography
disp:Display_Settings
msn:Mission_Information
img_surface:Surface_Imaging
msn_surface:Surface_Mission_Information
nucspec:NucSpec_Observation_Properties
rings:Ring_Moon_Systems
sp:Spectral_Characteristics
speclib:Spectral_Library_Product
msss_cam_mh:MSSS_Camera_Mini_Header
proc:Processing_Information
survey: Survey

voxparcxls commented 3 years ago

I've opened a PR for branch: PLAID_Issue21 when unit tests are complete.

jordanpadams commented 3 years ago

@voxparcxls looks great! can we also make sure whatever is needed to add those to the interface is documented if it hasn't already been?

jordanpadams commented 3 years ago

also, what do you mean by unit tests? is there a test suite in this package somewhere?

jordanpadams commented 3 years ago

closed per #27