All products are assumed to be Product_Observational by PLAID

[jordanpadams]

🐛 Describe the bug

Whenever I try to create a product not Observational (e.g. Document, Context, etc.), the software tries to drop this into Product_Observational and it does not work.

Minimal support should include: See https://pds.nasa.gov/datastandards/documents/im/v1/index_1G00.html#class_pds_observation_area for:

• Product_Observational

See https://pds.nasa.gov/datastandards/documents/im/v1/index_1G00.html#class_pds_context_area for:

• Product_Context
• Product_Document
• Product_Collection
• Product_Bundle

[jordanpadams]

bug may be here: https://github.com/NASA-PDS/PLAID/blob/2511e5cd6e40499e5ce7edca0699bb74cc92eab8/php/interact_db.php#L570

[voxparcxls]

@jordanpadams

The two criteria for Issue#25 to include 2 product types (Collection, Bundle) and fix XML mutator to ascribe correct outer <Product_Type> tag to all 7 types

• Types: Collection , Bundle
• <Product_Type> fix not complete as of yet

Product Type Collection, Bundle product manually tested using cases from: (https://pds.nasa.gov/data/pds4)

[jordanpadams]

@voxparcxls is there anything I can do to get this moving forward? Is there somewhere you are blocked?

[voxparcxls]

@jordanpadams For the product_type XML bug, there's nothing large thats blocking me. I just need to retrieve the product selection POST data without it interrupting the following Label pages.

I can use the rest of today to narrow that down. And open PR when it's ready.

[voxparcxls]

@jordanpadams

P.S., the dev version is up on: https://miplvm-docker1.jpl.nasa.gov/plaid if you would want to try it.

I'll be fully migrating the DB and updating for Issue#25

[voxparcxls]

@jordanpadams

Product_Type names are now prepended to each respective products:

• Product_Observational
• Product_Document
• Product_Context
• Product_Collection
• Product_Bundle

Test for Product_Context : https://pds.nasa.gov/data/pds4/context-pds4/node/node.geoscience_1.0.xml

[jordanpadams]

@voxparcxls looks like there is still something funky going on.

It looks like it is inserting an extra xml version and Product_Context into the label?

[voxparcxls]

Here's the Label product type selection.

I'll open a branch for the Product_Context fixes.

[voxparcxls]

@jordanpadams

Context Label Output is fixed. Removed resting label error.

• Removed empty <Discipline_Area></Discipline_Area> tag from _ProductContext labels
• Product_Context no longer has

Both fixed included in Branch: PLAID_Issue25

[jordanpadams]

@voxparcxls is this branch ready for a PR?

[voxparcxls]

@jordanpadams

Yes #25 PR is almost ready. I'm writing up the summary for it, and should be opened in a few hours.

Dev-Deployment UPDATE:

• The new image is pushed to Artifactory: cae-artifactory.jpl.nasa.gov:16001/gov/nasa/jpl/ammos/ids/plaid/plaidimage:V3
• Now configuring the DB container for dev, mariadb:10.3.23. (same version as live PLAID)

I will give status on dev deploy this afternoon.

[voxparcxls]

@jordanpadams

Test cases took longer than expected and sidetracked opening the PR.

Working on publishing the dev deployment ASAP.

[jordanpadams]

closed per #27