NASA-PDS / PLAID

APPS PDS Label Assistant for Interactive Design (PLAID). See an overview of the software on YouTube. https://www.youtube.com/watch?v=WCo8erW_rL8
https://plaid.jpl.nasa.gov
Other
9 stars 0 forks source link

As a developer, I want to see exception data #31

Open nutjob4life opened 2 years ago

nutjob4life commented 2 years ago

💪 Motivation

So that I can more effectively containerize, open-sourcerize, and otherwise whip APPS PLAID into shape (especially with regard to how #30 is growing in scope), it would be great to see exception and error condition details.

📖 Additional Details

In eight different locations (and perhaps more) in the APPS PLAID code, there are lines like these:

} catch (PDOException $ed) {
    //print($ex->getMessage()); // Don't print any error message, for security reasons
    return true;
}

That makes debugging APPS PLAID about 43× more difficult.

I get that PHP is awful and sort of insecure by default but there probably is some way to at least write exception details to the server log without it also going to the HTTP client.

⚖️ Acceptance Criteria

Given an exceptional condition When I perform viewing the server log via docker-compose logs plaid Then I expect to see stack traces or other exception data

⚙️ Engineering Details

jordanpadams commented 2 years ago

@nutjob4life copy that. i honestly have never figured out how to actually effectively debug PHP, so may need some help here. if you have any ideas on how we can log these errors and put that in there, I am all ear. not sure if @voxparcxls has any ideas that can help us?