NASA-PDS / PLAID

APPS PDS Label Assistant for Interactive Design (PLAID). See an overview of the software on YouTube. https://www.youtube.com/watch?v=WCo8erW_rL8
https://plaid.jpl.nasa.gov
Other
9 stars 0 forks source link

Resolve #32 #36

Closed nutjob4life closed 2 years ago

nutjob4life commented 2 years ago

🗒️ Summary

Merge this—if you dare—to resolve #32. This upgrades PHP from 5.6 to 7.4.27 which, as of this writing, is considered safe. Note that 8.1 is out, however there were an even higher number of issues trying to jump all the way to it.

⚙️ Test Data and/or Report

$ cd /tmp
$ python3 -m venv venv
$ cd venv
$ bin/pip install --quiet --upgrade setuptools pip
$ bin/pip install --quiet selenium webdriver_manager
$ curl --silent --location https://raw.githubusercontent.com/NASA-PDS/PLAID/main/tests/create_context_label_test.py | sed -e 's/Eyasu.T.Haile@jpl.nasa.gov/kelly@jpl.nasa.gov/' -e 's/pass/x/' > run.py
$ bin/python run.py
…
$ echo \U+1F389
🎉

♻️ Related Issues

jordanpadams commented 2 years ago

@voxparcxls can you please test and review these changes?

voxparcxls commented 2 years ago

@jordanpadams
@nutjob4life

PR looks good!

1. New PHP 7.4.27 worked great.

2. Selenium test ran successfully.

Screen Shot 2022-01-27 at 11 56 53 AM

3. Selenium create, populated, and previewed the label successfully.

Screen Shot 2022-01-27 at 11 54 04 AM

:clap: :smile:

nutjob4life commented 2 years ago

WOOOT! 🎉 Thanks @voxparcxls! 👏

jordanpadams commented 2 years ago

this was almost like a fun open source community fix and merge! we did it! 🎉

stirlingalgermissen commented 2 years ago

👏🎉