As a user, I want the SIP manifest to include valid URLs

NASA-PDS / deep-archive

PDS Open Archival Information System (OAIS) utilities, including Submission Information Package (SIP) and Archive Information Package (AIP) generators

https://nasa-pds.github.io/deep-archive/

Other

7 stars 4 forks source link

As a user, I want the SIP manifest to include valid URLs #102

Closed jordanpadams closed 3 years ago

jordanpadams commented 3 years ago

...so that I can ensure the validity of the SIP

Acceptance Criteria Given a valid bundle and pds-deep-archive installed When I perform the generation of a SIP manifest Then I expect all the URLs in the SIP to be valid

Engineering Tasks

[x] provide spot check of bundle.xml URL to make sure the URL is valid

jordanpadams commented 3 years ago

@nutjob4life since you are working on the other deep-archive ticket right now, does this seem like something that is pretty simple? basically, we just want to ping the base_url + bundle path that would go in the SIP to make sure it is valid. we can assume everything else in the SIP is valid for the time being.

nutjob4life commented 3 years ago

@jordanpadams are you thinking going beyond just if urlparse(url) succeeds but also urlopen(url) and get some valid data?

jordanpadams commented 3 years ago

@nutjob4life just urlparse(url) success. very simple to make sure the path exists. we can provide some more robust validation of URLs using the registry through some other component.

tloubrieu-jpl commented 3 years ago

@jordanpadams can you quickly add the acceptance criteria that Gary will use for I&T ? Thanks

jordanpadams commented 3 years ago

@tloubrieu-jpl done