NASA-PDS / deep-archive

PDS Open Archival Information System (OAIS) utilities, including Submission Information Package (SIP) and Archive Information Package (AIP) generators
https://nasa-pds.github.io/deep-archive/
Other
7 stars 4 forks source link

Require a validate output report be submitted in order to generate a SIP #11

Open jordanpadams opened 4 years ago

jordanpadams commented 4 years ago

Require a JSON report output from Validate be submitted to ensure the bundle is valid prior to generate. Report checks should include:

Applicable requirements Primary - :unicorn: #53

Related to #6

tbarnes4 commented 3 years ago

Hi @jordanpadams . SBN may have a concern with this given some of the things that have (or may) be reported as errors. For instance many of our collections include directory names of "data" or "document" which the validate tool calls out as an error.

jordanpadams commented 3 years ago

@tbarnes4 understood. we will need to work out some of these details, however, please feel free to propose issues for updates to validate for these false errors. some issues have been identified in the past with validate where there was a misinterpretation of the standards and/or the language in the standards have changed over time. additionally, i believe the issue you are seeing above actually throws a warning now as this was raised by other folks as well.,

tbarnes4 commented 3 years ago

@jordanpadams I will try and keep this in mind, and remind other invested SBN folks.

The issue I mentioned is still being reported as an error in:

gov.nasa.pds:validate Version 1.24.0 Release Date: 2020-09-08 22:33:13

I believe this is the current release based on the support pages.

jordanpadams commented 3 years ago

@tbarnes4 copy. that fix has only happened in the last couple months, so it is available in our unstable build: https://github.com/NASA-PDS/validate/releases/tag/v1.25.0-SNAPSHOT . Feel free to test this out or you can wait for a tag (coming in a couple months)