search

NASA-PDS / deep-archive

PDS Open Archival Information System (OAIS) utilities, including Submission Information Package (SIP) and Archive Information Package (AIP) generators
https://nasa-pds.github.io/deep-archive/
Other
7 stars 4 forks source link

Resolve #107 #119

Closed nutjob4life closed 2 years ago

nutjob4life commented 2 years ago

🗒️ Summary

Merge this if you dare and you'll finally resolve the blocked-for-multiple-sprints NASA-PDS/registry-api#448. Not gonna lie: this is an ugly merge. The pds.api-client changes frequently and incompatibly, even between 0.5.0 → 0.6.0 → 0.6.1 → 0.7.1 → 0.8.0.

⚙️ Test Data and/or Report

$ venv/bin/pytest
================================================= test session starts ==================================================
platform darwin -- Python 3.10.0, pytest-6.2.5, py-1.10.0, pluggy-1.0.0
rootdir: /Users/kelly/Documents/Clients/JPL/PDS/Development/nasa-pds/pds-deep-archive
plugins: cov-2.12.1, xdist-2.4.0, forked-1.3.0
collected 31 items                                                                                                     

src/pds2/aipgen/tests/test_functional.py sss........ssssssss...s.                                                [ 77%]
src/pds2/aipgen/tests/test_utils.py .......                                                                      [100%]

============================================ 19 passed, 12 skipped in 0.98s ============================================

♻️ Related Issues

nutjob4life commented 2 years ago

Thanks for the approval @collinss-jpl! I've gone ahead and made an additional comments-only commit to help explain why there's so many try…except blocks to work with the mercurial and constantly shape-shifting pds.api-client. Not everyone may be aware of just how often/randomly it changes, so it makes sense to document that 👍