NASA-PDS / deep-archive

PDS Open Archival Information System (OAIS) utilities, including Submission Information Package (SIP) and Archive Information Package (AIP) generators
https://nasa-pds.github.io/deep-archive/
Other
7 stars 4 forks source link

Fixes false positive in secret detection against baseline due to config change #154

Closed nutjob4life closed 9 months ago

nutjob4life commented 9 months ago

🗒️ Summary

The problem wasn't that a new secret suddenly appeared. Instead, it was that the .pre-commit-config.yaml wasn't included in the baseline configuration which resulted in a diff when the GitHub Action ran. The GitHub Action from SLIM is a bit primitive: it treats any diff as a new secret. In this case, the diff was a difference in config, not in secrets.

This also properly escapes the . in the regex for excluded files named .pre-commit-config.yaml.

⚙️ Test Data and/or Report

See https://github.com/nasa-pds-engineering-node/deep-archive/actions/runs/7035037799

♻️ Related Issues