Output SIP uses backslash in output URLs on Windows

NASA-PDS / deep-archive

PDS Open Archival Information System (OAIS) utilities, including Submission Information Package (SIP) and Archive Information Package (AIP) generators

https://nasa-pds.github.io/deep-archive/

Other

7 stars 4 forks source link

Output SIP uses backslash in output URLs on Windows #82

Closed jordanpadams closed 3 years ago

jordanpadams commented 3 years ago

Describe the bug Output in SIP:

e5a8de222f6347070867d6d0b83f0025    MD5 https://sbnarchive.psi.edu/pds4/orex\orex.mission\bundle_mission.xml    urn:nasa:pds:orex.mission::7.0

To Reproduce

Expected behavior A clear and concise description of what you expected to happen.

Version of Software Used Output from validate -V

Desktop (please complete the following information):

pds.deeparchive 0.2.0

nutjob4life commented 3 years ago

😮

nutjob4life commented 3 years ago

Hi @jordanpadams! it looks like there are backslashes in the AIP files too:

Screen Shot 2020-10-08 at 7 34 36 PM

But as I recall from an early design example, that was supposed to be the case. Then this commit commented-out the backslashes (with the added "injury" of commenting-out code without a comment explaining why 😂).

So—while I'm in here—should AIPs be forward slashes as well? 🤔

jordanpadams commented 3 years ago

@nutjob4life i remember that too, but let's fix both? windows can mostly support '/' but unix totally freaks out at backslash