NASA-PDS / doi-service

Service and tools for generating DOIs for PDS bundles, collections, and data sets
https://nasa-pds.github.io/doi-service
Other
2 stars 3 forks source link

DOI Service should be generating landing page URL when none is provided #266

Closed collinss-jpl closed 2 years ago

collinss-jpl commented 3 years ago

๐Ÿ› Describe the bug

Release submissions to DataCite require a URL be assigned before they are accepted. The DOI service should be generating a landing page URL from a template in the INI config if no URL has been provided. There should be logic to cover URL creation from both PDS4 (LIDVID) and PDS3 identifiers.

๐Ÿ“œ To Reproduce

Steps to reproduce the behavior:

  1. Submit a Release request using a record with no url field assigned.
  2. The request will be rejected by DataCite with a 422 error

๐Ÿ•ต๏ธ Expected behavior

url field is properly filled in by service during the "completion" step of the Release action.

๐Ÿ“š Version of Software Used

v2.0.0

๐Ÿฉบ Test Data / Additional context

๐ŸžScreenshots

๐Ÿ–ฅ System Info


๐Ÿฆ„ Related requirements

โš™๏ธ Engineering Details