NASA-PDS / doi-service

Service and tools for generating DOIs for PDS bundles, collections, and data sets
https://nasa-pds.github.io/doi-service
Other
2 stars 3 forks source link

Default keywords/subjects are not always added to DOI records #273

Closed collinss-jpl closed 2 years ago

collinss-jpl commented 2 years ago

๐Ÿ› Describe the bug

The DOI service provides a configuration setting to specify one or more keywords/subjects to include with every DOI record minted by the service. However, this field is not used, and default keywords are only added when a DOI record is created from a PDS4 label. The service needs to ensure the default keywords are also present for records created from spreadsheets or DataCite JSON labels.

๐Ÿ“œ To Reproduce

Steps to reproduce the behavior:

  1. Ensure the INI config for the service defines a comma-delimited list of values for OTHER.global_keyword_values (typically PDS,PDS4)
  2. Submit a reserve request using a valid XLS, CSV or DataCite JSON label (that does not already contain expected default keywords)
  3. Observe that the DataCite JSON label returned does not contain the expected default keywords defined by the INI config

๐Ÿ•ต๏ธ Expected behavior

The DOI record returned from a reserve, update or release request should always include a "subjects" field which contains, at minimum, the values specified in the OTHER.global_keyword_values section of the INI config.

๐Ÿ“š Version of Software Used

v2.0.1

๐Ÿฉบ Test Data / Additional context

๐ŸžScreenshots

๐Ÿ–ฅ System Info


๐Ÿฆ„ Related requirements

โš™๏ธ Engineering Details

jpl-jengelke commented 2 years ago

A test file -- doi5.xlsx ZIPped test file -- doi5.xlsx.zip