NASA-PDS / doi-service

Service and tools for generating DOIs for PDS bundles, collections, and data sets
https://nasa-pds.github.io/doi-service
Other
2 stars 3 forks source link

Spreadsheet parsers do not handle blank rows gracefully #291

Closed collinss-jpl closed 2 years ago

collinss-jpl commented 2 years ago

๐Ÿ› Describe the bug

Providing a spreadsheet file (CSV or XLS) as input with one or more blank rows can cause unhelpful exceptions to be raised. The service should be able to process or skip blank rows without raising an error.

๐Ÿ“œ To Reproduce

Steps to reproduce the behavior:

  1. Submit the attached XLS spreadsheet to the service via the reserve action
  2. Observe that the following exception is raised: pds_doi_service.core.input.exceptions.CriticalDOIException: 'NaTType' object has no attribute 'lower'

๐Ÿ•ต๏ธ Expected behavior

Service should process the spreadsheet with blank rows without raising an exception.

๐Ÿ“š Version of Software Used

v2.1.0

๐Ÿฉบ Test Data / Additional context

DOI_reserve_M2020_IMG_Release2_v2.xlsx

๐ŸžScreenshots

๐Ÿ–ฅ System Info


๐Ÿฆ„ Related requirements

โš™๏ธ Engineering Details