NASA-PDS / doi-service

Service and tools for generating DOIs for PDS bundles, collections, and data sets
https://nasa-pds.github.io/doi-service
Other
2 stars 3 forks source link

Tag and deploy new release per #331 #342

Closed jordanpadams closed 2 years ago

jordanpadams commented 2 years ago

💡 Description

tloubrieu-jpl commented 2 years ago

Hi @c-suh, @viviant100 , I tagged a new release of doi-service 2.2.1. Can you deploy it on pdscloud-prod1, pdscloud-prod2 and pdscloud-gamma and let Ron know that it contains the fix for this ticket https://github.com/NASA-PDS/doi-service/issues/328

viviant100 commented 2 years ago

@tloubrieu-jpl does this new release of doi-service 2.2.1 also require python 3.9.10+ to avoid the error I&T encountered in the previous release?

c-suh commented 2 years ago

@viviant100 and @tloubrieu-jpl I upgraded doi-service to 2.2.1 on pdscloud-gamma only. Let me know if I should wait or proceed. Thank you!

viviant100 commented 2 years ago

Thanks @c-suh. doi-service 2.2.0 errored out with python 3.9.7. @tloubrieu-jpl can help us confirm if this is part of improvement in 2.2.1. If not, we'll upgrade python to 3.9.10+ on pdscloud-gamma and test it before roll out to production.

tloubrieu-jpl commented 2 years ago

Hi @viviant100 , sorry I don't recall this issue with python 3.9.7 and doi-service 2.2.0, I don't think we have a fix for that. Is there a ticket tracking that ?

viviant100 commented 2 years ago

@tloubrieu-jpl the error was mentioned in the ticket https://github.com/NASA-PDS/doi-service/issues/328 by Gary.

tloubrieu-jpl commented 2 years ago

@viviant100 I missed it earlier. We did not do any fix for that.

I've just tested the ticket #328 with my local environment having python 3.9.1 and it worked.

I suggest that we create a ticket if this happens again in production of gamma.

viviant100 commented 2 years ago

@jordanpadams @tloubrieu-jpl doi-service 2.2.1 is now deployed to pdscloud-* and tested. Ron is informed this version (v2.2.1) contains the fix for ticket https://github.com/NASA-PDS/doi-service/issues/328.

jimmie commented 2 years ago

Everything deployed and proven.