search

NASA-PDS / doi-service

Service and tools for generating DOIs for PDS bundles, collections, and data sets
https://nasa-pds.github.io/doi-service
Other
2 stars 3 forks source link

Issue 336 - DOI-service application inaccurately reports LID as being invalid #353

Closed alexdunnjpl closed 2 years ago

alexdunnjpl commented 2 years ago

🗒️ Summary

Applies minor fixes to LIDVID validation logic and related exception messages. Adds tests for new/changed validation elements.

⚙️ Test Data and/or Report

Unit tests pass (except linting, which failed prior to changes) Behavioural tests unable to be run per #352

♻️ Related Issues

fixes #336

alexdunnjpl commented 2 years ago

Thanks @nutjob4life - will merge once checks have completed again.

jordanpadams commented 2 years ago

@alexdunnjpl it looks like we have some linter errors? https://github.com/NASA-PDS/doi-service/runs/7862664466?check_suite_focus=true

alexdunnjpl commented 2 years ago

@jordanpadams the linter was producing a tonne of errors when run against a freshly-cloned main - I assumed it was a known/in-progress thing and not something to worry about in the short term.

How would you like it handled?

jordanpadams commented 2 years ago

@alexdunnjpl ugh. copy. ok. I wasn't aware of that. let's leave it for now.

nutjob4life commented 2 years ago

@alexdunnjpl ugh. copy. ok. I wasn't aware of that. let's leave it for now.

I thought the doi-service linted correctly. It was one of the first big repositories @MJJoyce and I set up with the template repository paradigm.

I just noticed that we don't pin the versions of tools like flake8 in the setup.cfg; so it's possible a newer version of one of the QA tools discovered problems that weren't problems in the past.

alexdunnjpl commented 2 years ago

Just ran tests against af3d94bb, confirmed 1075 errors from flake8