NASA-PDS / doi-service

Service and tools for generating DOIs for PDS bundles, collections, and data sets
https://nasa-pds.github.io/doi-service
Other
2 stars 3 forks source link

Issue 335 copyright metadata #357

Closed alexdunnjpl closed 1 year ago

alexdunnjpl commented 1 year ago

🗒️ Summary

Implements a rights-management statement class, adds rights management (rightsList) metadata to DataCite reservations and DOIDataCiteRecords, and sets rights-management metadata to a US government-works copyright, by default

⚙️ Test Data and/or Report

All tests pass except flake8 lint, no tests added.

♻️ Related Issues

fixes #335

jordanpadams commented 1 year ago

@alexdunnjpl @nutjob4life holding on merging this for the time being. awaiting some feedback from our PDS DOI expert to ensure we are doing this right :-)

jordanpadams commented 1 year ago

@alexdunnjpl you may be able to just add the licensing metadata update to this PR in the meantime.

alexdunnjpl commented 1 year ago

Behaviour as-implemented:

jordanpadams commented 1 year ago

@alexdunnjpl do we need to update the test data that is out there?

alexdunnjpl commented 1 year ago

@alexdunnjpl do we need to update the test data that is out there?

@jordanpadams I'm not sure. No tests failed, so I'm not sure if it's within the scope of existing tests. I'll take a closer look at that test data early next week.

jordanpadams commented 1 year ago

merging. will poke at test data if anything breaks.

alexdunnjpl commented 1 year ago

@jordanpadams I can't turn up any string references to these files and the commit histories are intractably-large in terms of identifying related files/modules/tests.

Given that tests aren't failing, I'd suggest it's not worth investigating further.