search

NASA-PDS / doi-service

Service and tools for generating DOIs for PDS bundles, collections, and data sets
https://nasa-pds.github.io/doi-service
Other
2 stars 3 forks source link

Numerous flake8 lint errors are temporarily disabled #366

Open alexdunnjpl opened 1 year ago

alexdunnjpl commented 1 year ago

🐛 Describe the bug

The following flake8 lint errors have been disabled to allow branch integration testing to pass without being flooded. B007, B008, B902, B950, D100, D101, D102, D103, D104, D107, D200, D202, D205, D212, D402, D403, D415, D417, E741, F401, F841, N805, N818

The codebase must be linted and brought into compliance, and these errors re-enabled in setup.cfg's flake8 section.

🕵️ Expected behavior

With the temporary extend-ignore removed and the permanent extend-ignore reinstated, tox's lint testing passes.

alexdunnjpl commented 1 year ago

@jordanpadams running both black and autopep8 result in minimal changes (not sure why since I assume flake8 is assessing PEP8 conformity).

Manually fixing the >1100 errors manually is obviously not a smart play right now.

I'll loop back to this when I have some free time, but will assume it's not a high priority unless you tell me otherwise.