Overhauls DOIPDS4LabelUtil.get_names() and its supporting private methods.
New implementation is more rigid, but more comprehensible and well-defined. If we want more flexibility we need to implement personal/organizational entities (like are used for authors and editors) properly as classes, rather than just Dicts. I understand this conversation is ongoing between @jordanpadams and other stakeholders as of last week.
Adds support for parsing of organizational names (ie those without separators).
Formats like F.Lastname are no longer supported. Supported formats (per new unit tests) are
[
"A. Dunn",
"Dunn, Alex",
"Dunn, A.",
"Dunn, A. E.",
"Dunn, A. E. F. G.",
"Dunn, Alexander E.",
"Dunn, Alexander E. F. G.",
"Jet Propulsion Laboratory",
"JPL",
"Google Inc.",
"Suffixed Jr., James",
]
🗒️ Summary
Overhauls DOIPDS4LabelUtil.get_names() and its supporting private methods.
New implementation is more rigid, but more comprehensible and well-defined. If we want more flexibility we need to implement personal/organizational entities (like are used for authors and editors) properly as classes, rather than just
Dicts. I understand this conversation is ongoing between @jordanpadams and other stakeholders as of last week.Adds support for parsing of organizational names (ie those without separators).
Formats like
F.Lastnameare no longer supported. Supported formats (per new unit tests) are⚙️ Test Data and/or Report
Unit tests pass
♻️ Related Issues
fixes #377