search

NASA-PDS / doi-service

Service and tools for generating DOIs for PDS bundles, collections, and data sets
https://nasa-pds.github.io/doi-service
Other
2 stars 3 forks source link

DOI GUI "Create DOI" does not WARN or ERROR when both "author" name columns are missing #386

Open rsjoyner opened 1 year ago

rsjoyner commented 1 year ago

🐛 Describe the bug

Submitted XLS with both the "last_name" (e.g., "Smith") and "first_name" (e.g., "john") columns are missing in XLS.

📜 To Reproduce

Steps to reproduce the behavior:

  1. Create DOI
  2. Has data been registered: NO
  3. Upload XLS
  4. See error

🕵️ Expected behavior

Expected a more explicit parsing ERROR that identifies that both the "last_name" and "first_name" columns are / were expected. An ERROR message is generated. But, only identifies "last_name" as missing.

📚 Version of Software Used

N/A

🩺 Test Data / Additional context

See enclosures. Let me know if you need more info.

D:\WINWORD\Data_Prep_HandBook\aaaVer_9_20130225\DOI_20150505\aaaTest_DOI_GUI_20220906\test_reserve_too_few_columns\DOI_go_nims_io_missing_status_last_first_Name_columns_20221017.xlsx

🏞Screenshots

See enclosure

🖥 System Info

🦄 Related requirements

⚙️ Engineering Details

error_missing_status_last_firstName_columns DOI_go_nims_io_missing_status_last_first_Name_columns_20221017.xlsx

jordanpadams commented 1 year ago

@rsjoyner do we really need authors when they reserve a DOI? as long as we catch this when they try to release a DOI, this should be ok, no?