search

NASA-PDS / doi-service

Service and tools for generating DOIs for PDS bundles, collections, and data sets
https://nasa-pds.github.io/doi-service
Other
2 stars 3 forks source link

Deploy ADS delivery script to operations #399

Closed tloubrieu-jpl closed 1 year ago

tloubrieu-jpl commented 1 year ago

💡 Description

Run the script Alex created to deliver our DOI records to ADS on a weekly basis.

NOTE: We should discuss how we want to deploy this to fit with some of our other "cron"-like jobs. Should this be run on EC2 or using the AWS scheduler?

jordanpadams commented 1 year ago

Note: Updated the priority of this script to be part of overall system deployment

c-suh commented 1 year ago

Script is running from cron although I'm unsure of the json file contents. Will open another issue for that, though, if that is not what it should be.

jordanpadams commented 1 year ago

@c-suh as one off smoke test can you run the script manually and post the output for @alexdunnjpl and I to review?

alexdunnjpl commented 1 year ago

@jordanpadams how questionable is it that zero DOIs were updated in the previous calendar week?

Output checks out, apart from that. The code is well-tested (he committed, committingly) so if that's not obviously wrong there's no issue here.

c-suh commented 1 year ago

@jordanpadams I ran the script by modifying the time in cron and sent the contents of the json file to Alex, which had 0 modified DOI records (like he just said). After that, I checked the sync logs. For DOIs starting with 10.260*, there haven't been any written for the past while (about a month, at least).