search

NASA-PDS / doi-service

Service and tools for generating DOIs for PDS bundles, collections, and data sets
https://nasa-pds.github.io/doi-service
Other
2 stars 3 forks source link

Sync script is pushing non-findable DOIs to ADS #408

Closed jordanpadams closed 11 months ago

jordanpadams commented 1 year ago

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

Per the DataCite POC, they are seeing draft DOIs in the reports.

🕵️ Expected behavior

I expected on Findable DOIs to be included.

📜 To Reproduce

Run the sftp_drop_weekly_roundup.py script and note there are draft DOIs in the report.

🖥 Environment Info

No response

📚 Version of Software Used

No response

🩺 Test Data / Additional context

No response

🦄 Related requirements

No response

⚙️ Engineering Details

No response

jordanpadams commented 1 year ago

@tloubrieu-jpl I think @alexdunnjpl is too swamped to work this right now. any way you could take a look? checking with ADS folks to check if they can detect this for us for the time being.

tloubrieu-jpl commented 1 year ago

Ok I will look at that

alexdunnjpl commented 1 year ago

If they're doing anything programmatic with the output, it should be simple for them to filter by status - I'm 90% sure that's included in there.

Either way, should be a quick fix in the script - just add an appropriate status filter to the enumeration

tloubrieu-jpl commented 9 months ago

Skip I&T because the other related tickets, including the initial development of this script did not go through I&T.