search

NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/
Apache License 2.0
0 stars 4 forks source link

Install DOI Search In DOI UI #106 #121

Closed eddiesarevalo closed 2 years ago

eddiesarevalo commented 2 years ago

🗒️ Summary

DOI Search has been installed into the DOI UI. Integration bugs have been addressed in the doi search, #117 and #106

♻️ Related Issues

    - fixes #117
    - resolves #106
eddiesarevalo commented 2 years ago

Hello @tloubrieu-jpl, it looks like the package-lock.json is pointing to pds-wds-react version 0.0.1 which is the really broken version. It should be pointing to 0.0.2-beta.3

It looks like the versions are correct in the pds-wds-react package so the problem should be in the doi-ui. I will try to update the package-lock.json in the doi-ui

tloubrieu-jpl commented 2 years ago

Thanks @eddiesarevalo , should the file package-lock.json be managed in git ?

eddiesarevalo commented 2 years ago

@tloubrieu-jpl Yes the package-lock.json file should be tracked by git.

The package-lock.json file is different from the package.json as it keeps track of the specific versions of the modules used as dependencies. When the npm install command is run any conflicts between the dependencies will be resolved by checking this file. If this file doesn't exist then it is created then.

In the package.json file I have set the version of pds-wds-react to be used in the doi-ui to be 0.0.2-beta.3 I put an exact match as trying to to use the ~(minor version) or ^(major version) will ignore the beta version.

Once the latest pds-wds-react is merged back to main then we can remove the exact version and use the latest pds-wds-react.

Please try the doi-ui again.