search

NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/
Apache License 2.0
0 stars 4 forks source link

Null error message stays in a release/update scenario #123

Closed tloubrieu-jpl closed 2 years ago

tloubrieu-jpl commented 2 years ago

🐛 Describe the bug

See video

https://user-images.githubusercontent.com/60993872/157935510-faa73c91-df92-4e84-80e1-7fdee0cb8827.mov

📜 To Reproduce

Steps to reproduce the behavior:

  1. Go to '.release a doi'

  2. Input the url of a test dataset with warning in it for example, bundle_5.0.xml.zip

  3. Uncheck the ignore warning button

  4. Click on button upload label

  5. Warning shows

  6. Click on checkbox 'ignore warning'

  7. The submission works well but a message with null description stays

image

🕵️ Expected behavior

The error message should not be here

📚 Version of Software Used

Latest version of UI with latest version of UI deployed on pds-dev3 (from branch fix_api_for_ui)

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info

🦄 Related requirements

⚙️ Engineering Details

eddiesarevalo commented 2 years ago

@tloubrieu-jpl I am unable to reproduce this one completely with the bundle.xml file. If I deploy the bundle locally the server is unable to retrieve it from my computer so it will always return an error. Do you have an example of a working one that I can try to get a success message?

tloubrieu-jpl commented 2 years ago

Example of URL with a PDS4 bundle: https://pds-imaging.jpl.nasa.gov/data/nsyt/insight_cameras/bundle_6.0.xml

eddiesarevalo commented 2 years ago

@tloubrieu-jpl This pds4 bundle URL gives me this error: Screen Shot 2022-03-21 at 1.03.03 PM.png Maybe in the next break out we can take a look at this one? I just need one that will give me a success message.

tloubrieu-jpl commented 2 years ago

I am also unable to reproduce this error https://github.com/NASA-PDS/doi-ui/issues/125 maybe it was an side effect of bug since I had this error in the same test scenario