NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/
Apache License 2.0
0 stars 4 forks source link

Fix NodeJS GitHub workflow #213

Open anilnatha opened 1 year ago

anilnatha commented 1 year ago

Our GH workflow that checks for build issues related to NodeJS versions 14.x, 16.x, and 18.x is failing

A recent PR resolved a couple issues related to the build failures; however, the workflow's jobs continue to fail.

Observations:

  1. The tests for NodeJS 14 and 16 fail after what appears to be a successful build. In my local testing, I found that running npm run test produces one test failure which may be a good starting point as this command is part of the GitHub Workflow.
  2. Running npm run build locally succeeds.
  3. The app presently doesn't run locally when using NodeJS >18.x so this test may need to be removed.