search

NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/
Apache License 2.0
0 stars 4 forks source link

On release screen, have only one "ignore warning" checkbox #31

Closed tloubrieu-jpl closed 3 years ago

tloubrieu-jpl commented 3 years ago

The same value can be used for both "save" and "release"

Acceptance criteria: When the user release a DOI in the UI Then: the same checkbox enable to force warning occuring when he saves or release the DOI

c-suh commented 3 years ago

@tloubrieu-jpl can you attach a screenshot? I haven't come across any "ignore warning" checkboxes

tloubrieu-jpl commented 3 years ago

Sorry, here some details: You should:

  1. click on release
  2. select one DOI or LIDVID, for example urn:nasa:pds:lab_shocked_feldspars_3::3.0
  3. you should see the screenshot

image

c-suh commented 3 years ago

Screen Shot 2021-03-16 at 2 45 16 PM

I also searched the code for any checkbox-like elements but came up empty. I will pull the latest code and try again. That did the trick - I needed to pull the latest code. Thank you for the screenshot!

tloubrieu-jpl commented 3 years ago

Cool!

c-suh commented 3 years ago

Screen Shot 2021-03-17 at 11 59 45 AM

@tloubrieu-jpl let me know if you would like it placed differently

tloubrieu-jpl commented 3 years ago

@c-suh good point, i don't have a huge expertise in that domain but I also felt that this can be improved. I think save and release button can be on the same line. Keep them centered for now, so that it is consistent with the reserve layout. But honestly, whatever you think is good will work for me.

c-suh commented 3 years ago

@tloubrieu-jpl apologies, to clarify: since I am temporarily filling in for Eddie, I'm hesitant to change the style too much from what he has implemented, but if there is a strong preference for the upcoming demonstration, I will make the changes.