search

NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/
Apache License 2.0
0 stars 4 forks source link

Enhancements #32

Closed c-suh closed 3 years ago

c-suh commented 3 years ago

Resolves https://github.com/NASA-PDS/pds-doi-ui/issues/31 Resolves https://github.com/NASA-PDS/pds-doi-ui/issues/30

c-suh commented 3 years ago

If a style change is desired, I can do so before merging this into the master branch. Or shall I keep the work done during Eddie's leave on a separate branch?

c-suh commented 3 years ago

@tloubrieu-jpl I do not think it is any more complicated. My preference would be to have it on the same screen so that the user, without having to navigate/click back to the editable information, would have the opportunity to fix and attempt another save. However, I agree with you that consistency is important and will make this match the existing user flow.

Thank you for the heads up about the cancelled demo! I will still aim to complete this task within the current sprint.

tloubrieu-jpl commented 3 years ago

@c-suh yes, that is better to have the warning on the same page, so that users can see what the error related to. So you can leave that way for the SAVE button. I will create a ticket to update the warning/error display for reserve and release.

Here is the ticket to better manage warnng/error messages: #34