search

NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/
Apache License 2.0
0 stars 4 forks source link

Allow user to search by DOI, LIDVID, or partial and List results #38

Closed c-suh closed 3 years ago

c-suh commented 3 years ago

Resolves #25 Resolves #33

c-suh commented 3 years ago

@tloubrieu-jpl

I cut and paste a URN from the table and search for it, but I had an answer No exact match.

  1. I had meant to seek clarification on this: are LIDVIDs (complete with a version) unique? And can one DOI be assigned to more than one LIDVID? The test data has several instances of multiple DOIs and multiple LIDVIDs, e.g.
DOI LIDVID
10.17189/29380 107::1.0
10.17189/29380 108::1.0
10.17189/29471 urn:nasa:pds:lab_shocked_feldspars_3::3.0
10.17189/29474 urn:nasa:pds:lab_shocked_feldspars_3::3.0

These answers to these two questions might require me to tweak the application logic.

The error might be on the API side or maybe we need clarification on how to handle multiple lidvid versions in the application. I don't think we discussed that yet.

  1. The multiple LIDVID versions is not something I recall discussing. The message saying "No exact match found" is how the application handles the search results. Let me know how you would like this changed.

    Easier: We should have some text before the related DOIs list. That could be "Related DOIs" but it is @jordanpadams 's call.

  2. @edwardbarraza's input could also be helpful here regarding usability and clearly conveying information.

    At last, for the search box, I have the habit to press enter after I typed my search criteria and I was expecting that to search but here we need to click the magnifier. Would that be possible to also trigger search when a enter is pressed.

  3. Hitting Tab then Enter will trigger the search. Although not ideal, the behavior when you hit Enter (a refresh or reload of the application) is an existing bug that might warrant its own ticket, and due to time constraints (and no complaints or ticket), I left it as is. However, I would be happy to look into it.
tloubrieu-jpl commented 3 years ago

@tloubrieu-jpl

I cut and paste a URN from the table and search for it, but I had an answer No exact match.

  1. I had meant to seek clarification on this: are LIDVIDs (complete with a version) unique? And can one DOI be assigned to more than one LIDVID? The test data has several instances of multiple DOIs and multiple LIDVIDs, e.g.

DOI LIDVID 10.17189/29380 107::1.0 10.17189/29380 108::1.0 10.17189/29471 urn:nasa:pds:lab_shocked_feldspars_3::3.0 10.17189/29474 urn:nasa:pds:lab_shocked_feldspars_3::3.0

This should not happened. I think we need to check the backend behavior. I will create a ticket for that.

tloubrieu-jpl commented 3 years ago

@c-suh I made a quick test with the API being updated with the history of DOIs and I am realizing that there might be a mismatch in the status you expect and the one we have: the status 'Registered' is the one we use when the DOI is released. I this case we should be able to update the DOI from the table of DOIs. Is that something you considered yet ? I was thinking your code might expect 'Released' as a status or simply we forgot to mention that case before.

There is also an error when I click on Release for example of lidvid "urn:nasa:pds:cassini_vims_saturn:document:vims-browse-interpretation-key".

Sorry I completely changed the data and also upgraded the API version I am using with your code... You can test yourself as it is deployed on pds-dev3.

Thanks Catherine

c-suh commented 3 years ago

Hi @tloubrieu-jpl! I was not aware of the status 'Registered' (or rather, I knew it as 'Released'), and I will update the code accordingly. I see the data and am excited to test with it and the new API version and will also look into the error you mentioned.

c-suh commented 3 years ago

@tloubrieu-jpl for all items which I've tried so far, I'm getting the same error.

Also, I am aware of 4 status values but see only 2 in this new test data. Would it be possible to get a few which are also "Draft" and "In Review"?

tloubrieu-jpl commented 3 years ago

@tloubrieu-jpl for all items which I've tried so far, I'm getting the same error.

  • error name: NoTransactionHistoryForLIDVIDException
  • error message: Could not find an OSTI Label associated with LIDVID <lidvid>. The database and transaction history location may be out of sync. Please try resubmitting the record in reserve or draft.

You are right I missed to update the transaction history files. I will do it now.

Also, I am aware of 4 status values but see only 2 in this new test data. Would it be possible to get a few which are also "Draft" and "In Review"?

Since we generated the database from DOIs submitted at OSTI, they can only be in reserved or registered status. The other 'intermediary' status are not available in the OSTI database but only in Ron's system (he's managing the DOI registration process).

tloubrieu-jpl commented 3 years ago

@c-suh the api on pds-dev3 now works with the transaction history, I will do a few tests and I should be able to merge this pulll request.