Address requested changes on closed PR and Iterative enhancements

NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/

Apache License 2.0

0 stars 4 forks source link

Address requested changes on closed PR and Iterative enhancements #57

Closed c-suh closed 3 years ago

c-suh commented 3 years ago

Resolves #56

Remove comments and unused imports and variables
Move styling from global CSS to within individual files with makeStyles
Remove outer scroll from page with search results

Resolves #48

Change text to 'Upload URL'
Move buttons to be inline (Upload URL to input, Save to Submit)

Resolves #50

Add i icon and text for Keywords text box
Add i icon and text for general questions about process or information requested

Resolves #54

Have Update/Release page follow design similar to Create
- Submitter and Node at top
- Question asking if publicly available
- option to upload metadata by PDS4 Label URL
Add DOI of item at top of page in disabled/non-clickable field

Misc request

Remove word 'Error' from error or warning alerts

c-suh commented 3 years ago

I've also pushed for this PR the remaining items from https://github.com/NASA-PDS/pds-doi-ui/issues/48. @eddiesarevalo let me know how these look. Thank you!

c-suh commented 3 years ago

Latest push (https://github.com/NASA-PDS/pds-doi-ui/pull/57/commits/1a404f5ed6a54b92a0d721de4c3d368e7931b8a2) resolves issue #54

jordanpadams commented 3 years ago

@eddiesarevalo since this PR is addressing issues you raised, I will leave it to you to approve and merge.

c-suh commented 3 years ago

@jordanpadams sorry, I might have misunderstood from our meetings a couple weeks ago. I thought these issues minor enough to keep working on the same branch so as to fold into one PR:

https://github.com/NASA-PDS/pds-doi-ui/issues/56 (Eddie's requested changes from a previous PR)
https://github.com/NASA-PDS/pds-doi-ui/issues/48 (Enhancements per initial implementation of mockups)(rest of)
https://github.com/NASA-PDS/pds-doi-ui/issues/54 (Update Release and Update DOI pages to follow similar design as Create DOI page)
https://github.com/NASA-PDS/pds-doi-ui/issues/50 (Add additional help information throughout DOI UI)(in progress and will be done today)

Should I rename this PR and edit the initial description, or rebase this branch and force-push then create separate branches and PRs for the other 3 items?

c-suh commented 3 years ago

@NASA-PDS/pdsen-ui-committers, this PR will not have any more pushes and is ready to be reviewed and hopefully closed this sprint.

tloubrieu-jpl commented 3 years ago

Merged in branch routing-fixes