search

NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/
Apache License 2.0
0 stars 4 forks source link

Add Feedback Widget #49 #59

Closed eddiesarevalo closed 3 years ago

eddiesarevalo commented 3 years ago

Added the feedback widget from feedback-widget be included with the doi ui build. A captcha is still needed from the pds operator.

resolves #49

c-suh commented 3 years ago

@eddiesarevalo overall looks great, but I've noticed a few small things which are simply for consistency's sake. Mainly, the sentence in the footer is missing. This isn't required if the badge is displayed, which I would swear I had gotten rid of, except for the fact that it's obviously not gone. I've the itch to address this (and other items I've noticed, which would in turn address the other small, stylistic differences I've noticed) in the feedback widget repo and will ask @jordanpadams about doing so, but given that several nodes have already deployed this, it might be more time than it's worth and could stay as is.

So, if the feedback widget stays as is without another release, there is the question of how exact a replica this should be, and the answer to that determines if more changes for this PR are required. Functionally, this should be fully set up once the DOI UI is deployed and its domain added to the recaptcha list, so I give my irrelevant approval to merge this PR. @tloubrieu-jpl, let us know how you would like to proceed. Thank you!

jordanpadams commented 3 years ago

@c-suh let's discuss your comment above. not sure what you are seeing and what we want to do. i am going to merge this right now, but we can create a separate ticket for what you are looking for. we definitely want our feedback widget to look 100% the same across our web applications. so if things are not, we should figure out how we can do that (e.g. link to some config.js or other files that are at pds.nasa.gov?)