NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/
Apache License 2.0
0 stars 4 forks source link

Add Reserve Form With Connection To Reserve API #1 #5 #6

Closed eddiesarevalo closed 3 years ago

eddiesarevalo commented 3 years ago

The form for entering reserve API parameters including a parsed excel sheet has been added. The form includes a submit button that will send the parameters and parsed excel sheet to the reserve API.

Resolves #1
Resolves #5

eddiesarevalo commented 3 years ago

Thanks Eddie. I was not able to make reserve button work.

I have also some comments on the UI, see

Screen Shot 2020-11-19 at 10 06 14 AM

Thank you for your feedback, I have only been doing minimal styling so far so I can take it into account. I have just been working on functionality not really the styling. I was thinking of doing the styling on a different issue as I wanted to use Mikes styling from the DOI and to make the forms look better. This takes some time though. I am not sure if we should include that in this pull request or after the app functionality is complete as it is simpler nearer the end.

tloubrieu-jpl commented 3 years ago

Thanks @eddiesarevalo for your feedback. The styling is not critical at all but the action menu should be removed and the reserve button should work (it did not in my deployment).

Thanks

eddiesarevalo commented 3 years ago

@tloubrieu-jpl I have made the changes except for the editable table and the styling which will come later. When you attempted to run this locally were there any errors thrown on the developer console or network tab? For the call to work a submitter email and node must be entered. Also an excel sheet must be uploaded.