NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/
Apache License 2.0
0 stars 4 forks source link

As an administrator, I want to deploy the ui from a release and be able to change the back-end API urls #63

Closed tloubrieu-jpl closed 2 years ago

tloubrieu-jpl commented 3 years ago

Motivation

...so that I can actually use the release package

Additional Details

The js files are minified and it is not easily editable.

Acceptance Criteria

Given a release package, e.g. https://github.com/NASA-PDS/pds-doi-ui/releases/tag/v0.3.0 When I perform the deployment procedure, see https://github.com/NASA-PDS/pds-doi-ui/releases/tag/v0.3.0 Then I expect to be able to edit a configuration file where I can set the back-end API url in a single string

Engineering Details

tloubrieu-jpl commented 3 years ago

@jordanpadams @eddiesarevalo The ticket does not need to be urgently processed since the deployment procedure will work by using git clone before this ticket is solved

tloubrieu-jpl commented 3 years ago

Note @eddiesarevalo that would also help to have a single string to update in the configuration, since now Config.js is: const Config = { api:{ reserveUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois', getDoiByLidvidUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois/', getDoiByDoiUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois', getDoiByPds4LabelUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois', releaseDoiUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois/', baseUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois/' } }

which is a lot a redundant string. Coud you also update that as part of this ticket ?

Thanks,

Thomas

jordanpadams commented 2 years ago

@eddiesarevalo think we can squeeze this into the work you are already doing?

eddiesarevalo commented 2 years ago

Note @eddiesarevalo that would also help to have a single string to update in the configuration, since now Config.js is: const Config = { api:{ reserveUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois', getDoiByLidvidUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois/', getDoiByDoiUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois', getDoiByPds4LabelUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois', releaseDoiUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois/', baseUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois/' } }

which is a lot a redundant string. Coud you also update that as part of this ticket ?

Thanks,

Thomas

These two are different. I'm not sure if they will change in the future: getDoiByIdentifier: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.2/doi', releaseDoiUrl: 'http://localhost:8085/PDS_APIs/pds_doi_api/0.2/doi/',

tloubrieu-jpl commented 2 years ago

Hi @eddiesarevalo ,

I don't think we should have different configuration.

The difference is getDoiByIdentifier is followed by ?parameter=value... and releaseDoiUrl is followed by '/'

but the base url should be the same. Does that work ?