search

NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/
Apache License 2.0
0 stars 4 forks source link

Routing fixes #66

Closed eddiesarevalo closed 3 years ago

eddiesarevalo commented 3 years ago

Fixed the issues caused by merging #22 #52 #57 together. The pull requests had to be updated with the router code. This also adds #65 through #52

resolves #22 resolves #52 resolves #57 resolves #65 resolves #64

I need @c-suh to verify that the latest changes are there and functional. I tested end to end with a dummy excel doi. @c-suh can use her tests to double check everything is working.

c-suh commented 3 years ago

@tloubrieu-jpl, I left a review above, but you might want to sign off on my points 1 and 2 as "fine as is"?

tloubrieu-jpl commented 3 years ago

Thanks @c-suh , I will create new tickets for your comments so that I can merge now. Thanks

tloubrieu-jpl commented 3 years ago

Hi @eddiesarevalo,

Were you able to change the buton label to create a new DOI after one is reserved ?

Thanks,

Thomas

eddiesarevalo commented 3 years ago

@tloubrieu-jpl I changed the label for the button. I also changed the basename subdiretory to '/dois'

tloubrieu-jpl commented 3 years ago

thanks @eddiesarevalo , is the basename subdiretory hardcoded ?

for the production deployment we want to deploy the build application in an apache directory and ideally the application would be agnostic of which apache directory it is deployed in.

eddiesarevalo commented 3 years ago

@tloubrieu-jpl Try to test this latest commit. It should allow deployment on any sub directory. I have only been able to test locally but you can try it on your server.

Use npm run build to get the built code.

tloubrieu-jpl commented 3 years ago

Thanks @eddiesarevalo that works. There is only a minor issue that does not prevent from merging and deploying on pds-gamma. I created a ticket #70