Search by DOI returns multiple records in different states

jordanpadams commented 3 years ago

🐛 Describe the bug

Not sure if this a bug on the DOI UI or the DOI Service, but a query for a specific DOI returns 2 records in 2 different states:

📜 To Reproduce

Steps to reproduce the behavior:

Start up DOI UI
Go to http://localhost:3000/#/search/10.17189/1522357
Get the following search results:

🕵️ Expected behavior

Should only return one record with the current state of the DOI.

** :unicorn: Applicable requirements 🦄 #36

jordanpadams commented 3 years ago

@collinss-jpl can we check if this is a problem with the API for the DOI UI?

collinss-jpl commented 2 years ago

@jordanpadams @tloubrieu-jpl I've taken some time to try to reproduce this using the latest version of the service and API (but without UI), and I cannot. I attempted to reproduce by:

Importing production DOI's from OSTI to local database
Moving the DOI used in the example (10.17189/1522357) back to draft so it has multiple entries in the Sqlite3 table
Querying for 10.17189/1522357 via list action directly, and through the API

In both cases, only the latest row for the DOI was returned. My guess is this issue was related to a bug in the database code for fetching the "is_latest" row that was fixed as part of an unrelated PR. However, its hard to say exactly because we've lost a lot of the commit history for the pds-doi-service repo. My recommendation would be to redeploy latest ver of DOI service, and see if you can still reproduce this bug. I'm fine with leaving this ticket open until then.

collinss-jpl commented 2 years ago

@jordanpadams @tloubrieu-jpl I went ahead and tried to reproduce this issue with the DOI service currently deployed on pds-dev3 and was still unable to. I pretty much followed the steps I outlined above:

Imported production OSTI records to local database (preexisting db seemed to be empty)
Moved DOI 10.17189/1522357 back to draft, and then even moved it forward to the "review" state for good measure
Queried 10.17189/1522357 via list action and through API. In both cases only most up-to-date row was returned.

I also tried to launch the UI to see if this issue was still occurring there, but I was unable to navigate to the search page using http://localhost:3000/#/search/10.17189/1522357, it just kept redirecting me to the "Reserve or Release" page.

@eddiesarevalo I also noticed that the UI still needs to be updated to point at v0.2 of the API. Besides just replacing "0.1" with "0.2" in the URL's, there have also been some updates to semantics of the endpoints themselves. I left an instance of the API running on pds-dev3 on port 8080. If you tunnel to that port on your local machine (ssh -L 8080:localhost:8080 pds-dev3) you can try out the new version by navigating to http://localhost:8080/PDS_APIs/pds_doi_api/0.2/ui/

tloubrieu-jpl commented 2 years ago

That did not show again. Not much time to check more.

NASA-PDS / doi-ui