NASA-PDS / doi-ui

The web interface for the PDS DOI Service providing the ability management PDS archive DOIs. See the DOI Service for more details on the available capabilities. https://nasa-pds.github.io/doi-service/
Apache License 2.0
0 stars 4 forks source link

Status Findable does not have actions or links in the UI #94

Closed tloubrieu-jpl closed 2 years ago

tloubrieu-jpl commented 2 years ago

🐛 Describe the bug

See screenshot from pds-gamma: https://pds-gamma.jpl.nasa.gov/dois/#/search/*

image

🕵️ Expected behavior

I think an Update button should be provided to the user.

📚 Version of Software Used

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info


🦄 Related requirements

⚙️ Engineering Details

tloubrieu-jpl commented 2 years ago

@collinss-jpl can you confirm 'findable' is equivalent to 'released' and that the available action in the UI, from this status, should be 'Update' ?

Thanks

collinss-jpl commented 2 years ago

@tloubrieu-jpl This is correct, "findable" is the DataCite equivalent of OSTI"s "released"

tloubrieu-jpl commented 2 years ago

Thanks @collinss-jpl , so should the UI still support Released ? Do we still have an enum with the supported Status ?

Thanks

collinss-jpl commented 2 years ago

@tloubrieu-jpl It's probably a good thing if the UI supports "Released" for backward compatibility, but now that all our existing DOI records have been transferred to DataCite, we shouldn't expect to see "Released" any more in our transaction database once its been initialized from DataCite.

tloubrieu-jpl commented 2 years ago

Ok, that works.

Do we have the list of status which should be supported somewhere in pds-doi-service repo or should we go to dataCite documentation ?

Thanks @collinss-jpl

collinss-jpl commented 2 years ago

@tloubrieu-jpl We've accumulated a number of status values in the service that no longer have much purpose (like "pending"), or I would like to remove from usage going forward (like the "reserved_not_submitted" status). What I can say is that the "draft", "review" and "findable" statues are the most likely candidates for the UI to display.

tloubrieu-jpl commented 2 years ago

Ok, then I will create another ticket for the status enum cleaning.

tloubrieu-jpl commented 2 years ago

Thr conclusion is that for status 'Findable' AND 'Release' the UI must propose the 'Update' action.