search

NASA-PDS / feedback-widget

Javascript widget for user feedback
https://github.com/NASA-PDS/feedback-widget#pds-feedback-widget
Apache License 2.0
2 stars 1 forks source link

Feedback cuts off Comment with special characters #14

Closed c-suh closed 2 years ago

c-suh commented 3 years ago

🐛 Describe the bug

TextArea submission is being cut off.

📜 To Reproduce

Steps to reproduce the behavior:

  1. Go to pds.nasa.gov
  2. Click on 'Need Help?' to open Feedback widget
  3. Enter comment and Submit
  4. Follow up with pds_operator to see what was received

🕵️ Expected behavior

Comment is cut off if a special character is used.

📚 Version of Software Used

v1.2.1

🩺 Test Data / Additional context

Special characters are the suspected culprit (not yet verified) because there is no maxLength set on the form element. This issue was brought to our attention when a user submitted feedback on an RMS site (email thread with subj: 'Feedback from pds-rings.seti.org')

🏞Screenshots

🖥 System Info

🦄 Related requirements

⚙️ Engineering Details

c-suh commented 2 years ago

Sorry; forgot best practices and hadn't done this on another branch, so there's no PR.

The fix has been made operational.

c-suh commented 2 years ago

Sorry; eschewed even more best practices. I hadn't noticed the whitespace differences which cluttered the original commit. This has been redone, and the relevant commit is https://github.com/NASA-PDS/feedback-widget/commit/84bcf42b0105fbd602239f59c16a5e03cf0b4d5f.