NASA-PDS / feedback-widget

Javascript widget for user feedback
https://github.com/NASA-PDS/feedback-widget#pds-feedback-widget
Apache License 2.0
2 stars 1 forks source link

Feedback says (CORS) error but submits #18

Closed c-suh closed 9 months ago

c-suh commented 2 years ago

πŸ› Describe the bug

On submitting something to the Feedback widget, a message will come up that "There was an error sending your feedback." Opening dev tools shows a CORS error. However, the submission goes through. This has been tested from the ATM site, two SBN PSI sites (https://arcnav.psi.edu/ and https://sbn.psi.edu/pds/) and the PDS gamma site.

Notes:

πŸ“œ To Reproduce

Steps to reproduce the behavior:

  1. Go to pds.nasa.gov
  2. Click on "Need Help?" to open the Feedback modal
  3. Fill in with your information, indicate it's for testing, and submit
  4. See error

πŸ•΅οΈ Expected behavior

Either the submission should not go through, or the feedback widget should give the "Thank you for making PDS a better site" message.

πŸ“š Version of Software Used

v1.3.0, at least on gamma

🩺 Test Data / Additional context

🏞Screenshots

image

πŸ–₯ System Info


πŸ¦„ Related requirements

βš™οΈ Engineering Details

jimmie commented 2 years ago

Ticket DSIO-2392 opened.

c-suh commented 2 years ago

Sent email to @viviant100 with updates. This is going in the to-do list for me to do after the swagger-ui related task.

acyu commented 2 years ago

I am unable to replicate this issue in Chrome. My version of Chrome is Version 105.0.5195.127. Perhaps this is a browser related issue? Will try with different browser image

c-suh commented 2 years ago

Both Allan and I are not able to replicate this issue (although I encountered it at the time this issue was opened). However, Colleen and a PDS user are still encountering the error message while the feedback submission goes through. Further investigation is again paused while addressing other tasks.

jordanpadams commented 2 years ago

@c-suh we should try to get a better understanding of the specific browser and version they are using.

jordanpadams commented 2 years ago

@c-suh FYI, just submitted feedback fine through the RMS widget.

jordanpadams commented 1 year ago

@c-suh adding this back to the sprint backlog since it has reared its head again

c-suh commented 1 year ago

I am getting reacquainted with the details of this bug. Thus far, this is an issue on the nodes' websites which have the feedback widget installed. I just noticed the ticket linked by Jimmie above, and I think we need to continue that conversation. There's an issue with submitting from the pds-engineering site as well, but it's TBD if it's the same or a different issue.

c-suh commented 1 year ago

Talked with Thomas. Have reopened DSIO-2392 with the SAs with a request.

c-suh commented 1 year ago

Still waiting to hear back from the SAs.

nutjob4life commented 1 year ago

Ticket comment did not reopen it. Have let SAs know directly.

c-suh commented 1 year ago

Talked with a SA who requested I open a new ticket: DSIO-4244.

c-suh commented 1 year ago

SA has provided new information which I must look at.

tloubrieu-jpl commented 1 year ago

For SBN the error is related to the recapcha service not being accessible: https://voight.psi.edu/recaptcha-v3-verify.php.

The CORS headers have been added to the cloudfront function but this is not working. A ticket DSIO-2392 with the SAs has been reopened to investigate a possible conflict with a response header policy.

jordanpadams commented 1 year ago

Note: Additional weirdness from https://pds.nasa.gov/tools/doi/#/search. When you try to submit feedback, the email says it is coming from pds-gamma.jpl.nasa.gov.

matthewtiscareno commented 1 year ago

The feedback button is still broken on the RMS website.

tloubrieu-jpl commented 1 year ago

Yes, sorry @matthewtiscareno we have been pulled away from that ticket because of other priorities. It is still in my to do list.

tloubrieu-jpl commented 11 months ago

Something needs to be done.

tloubrieu-jpl commented 10 months ago

The CORS errors have been fixed by updating the cloudfront function which did not work as needed before.

All the feedbck widgets deployed (ENG, RMS, SBN) now work expect ATM which have a different error related to the recapcha verification, saying I am a bot.

tloubrieu-jpl commented 10 months ago

A new ticket has been created for the recaptcha error, see https://github.com/NASA-PDS/feedback-widget/issues/20

tloubrieu-jpl commented 10 months ago

The code is not saved on github but is deployed as a cloud front function add_cors_header.

gxtchen commented 8 months ago

@tloubrieu-jpl I am still seeing the error message.

tloubrieu-jpl commented 8 months ago

Hi @gxtchen , that is correct, I am reproducing that. I need to re-investigate that... Can you open a new ticket with the tag i&t and assign it to me ? Thanks.