NASA-PDS / harvest

Standalone Harvest client application providing the functionality for capturing and indexing product metadata into the PDS Registry system (https://github.com/nasa-pds/registry).
https://nasa-pds.github.io/registry
Other
4 stars 3 forks source link

Improve error handling for `document missing` response from OpenSearch #155

Open jordanpadams opened 3 months ago

jordanpadams commented 3 months ago

💡 Description

When a user tries to execute a harvest load, they are getting this error messages like this:

[ERROR] [_doc][urn:nasa:pds:relab:data_reflectance:offmt003a::1.0]: document missing
[ERROR] [_doc][urn:nasa:pds:relab:data_reflectance:offmt003b::1.0]: document missing
[ERROR] [_doc][urn:nasa:pds:relab:data_reflectance:offmt003c::1.0]: document missing
[ERROR] [_doc][urn:nasa:pds:relab:data_reflectance:offmt006a::1.0]: document missing
[ERROR] [_doc][urn:nasa:pds:relab:data_reflectance:offmt006b::1.0]: document missing
[ERROR] [_doc][urn:nasa:pds:relab:data_reflectance:offmt41bl::1.0]: document missing
[ERROR] [_doc][urn:nasa:pds:relab:data_reflectance:offmt41gr::1.0]: document missing
[ERROR] [_doc][urn:nasa:pds:relab:data_reflectance:offmt42a::1.0]: document missing
[ERROR] [_doc][urn:nasa:pds:relab:data_reflectance:offmt42b::1.0]: document missing

This is not really helpful or useful for a user. Let's catch this error and provide a more useful error message that can help a user debug the issue.

⚔️ Parent Epic / Related Tickets

Parent: #154

alexdunnjpl commented 4 days ago

@jordanpadams I'll happily speculate about what's relevant and how to usefully present it, but if @plawton-umd or another user can chime in on the following, I can probably deliver something better

From that, I can infer what information to display and how to display it (for example, it might be useful to supply a report in JSON format if it's desirable to do something to problematic elements with a script)

plawton-umd commented 3 days ago

@alexdunnjpl This specific error is not one I recall encountering. If I saw this, on my side I would check the paths and permissions for were the product is expected to be loaded from. However, it is not clear to me if this error message is referring to not finding the product in my source files or somewhere on the EN side of the interface.

My workflow looks like

Common errors I have encountered (I expect new ones with the move to MCP)

My resolution to these errors

alexdunnjpl commented 3 days ago

@plawton-umd fantastic, thanks for this