search

NASA-PDS / harvest

Standalone Harvest client application providing the functionality for capturing and indexing product metadata into the PDS Registry system (https://github.com/nasa-pds/registry).
https://nasa-pds.github.io/registry
Other
4 stars 3 forks source link

Remove node name from configuration as it is part of the connection now #160

Closed al-niessner closed 2 months ago

al-niessner commented 2 months ago

🗒️ Summary

Remove node name from config, update examples, and regenerate data binding.

⚙️ Test Data and/or Report

xmllint passes all examples:

$ xmllint --noout --schema configuration.xsd examples/bundles.xml examples/directories.xml examples/files.xml examples/xpaths.xml 
examples/bundles.xml validates
examples/directories.xml validates
examples/files.xml validates
examples/xpaths.xml validates

♻️ Related Issues

Step 5 of NASA-PDS/registry-common#48

al-niessner commented 2 months ago

@jordanpadams @tloubrieu-jpl

Design issue: removing node name prevents it from being in the document. Is this important or can it be deleted?

jordanpadams commented 2 months ago

@al-niessner if you mean the document being written to the Registry, then we have to figure something else out. That information must be in the Registry metadata. So we will either need to add it upon initial write or write a sweeper to do it.

Can we get this information from harvest or registry manager CLI argument?

al-niessner commented 2 months ago

@jordanpadams @tloubrieu-jpl

Yes, that is what I meant with respect to node name in metadata. I reestablished them. It maps the registry index name to the node name. If the mapping does not exist it tries a backup of removing '-registry' from the index name. If '-registry' is not in the index name it simply defaults to 'development'. Look at the indexNodeMap table to make sure I got the mapping correct.