NASA-PDS / harvest

Standalone Harvest client application providing the functionality for capturing and indexing product metadata into the PDS Registry system (https://github.com/nasa-pds/registry).
https://nasa-pds.github.io/registry
Other
4 stars 3 forks source link

New feature to allow harvest to set archive status #161

Closed al-niessner closed 1 month ago

al-niessner commented 1 month ago

🗒️ Summary

Allow harvest to define the archive status when it harvests the data.

⚙️ Test Data and/or Report

Validated by setting to certified and looked in DB. Also tried with fred and it failed giving a list of valid choices.

♻️ Related Issues

Closes #135 Requires NASA-PDS/registry-common#56

jordanpadams commented 1 month ago

@al-niessner is there any kind of integration tests we could add to the our registry test suite to verify the setting of archive status upon loading of the data?

al-niessner commented 1 month ago

@jordanpadams

We could add a trivial test that show that the default variable is updated. Not sure that does much but could offer a very modest amount of regression. Otherwise back to needing a running opensearch, secrets, test data, expectations that change with the data etc.

jordanpadams commented 1 month ago

@al-niessner thanks. I don’t think a test like that is necessary worth it. I will try to test this over the weekend.

tloubrieu-jpl commented 1 month ago

@al-niessner @jordanpadams, I suspect we will encounter the same issue that we are having on https://github.com/NASA-PDS/registry-mgr/pull/82#issuecomment-2276567447

But for now I am having a different issue:

% ./bin/registry-manager set-archive-status \
    -auth /Users/loubrieu/Documents/pds/registry/es-auth.txt \
    -es file:/Users/loubrieu/Documents/pds/registry/mcp_dev.xml \
    -packageId 8d12a9ba-2ba0-4d80-8ce9-65da271ecf89 \
    -status archived

[ERROR] Missing required parameter '-lidvid' or '-packageId

@al-niessner is that something you can reproduce ?

Thanks

al-niessner commented 1 month ago

@tloubrieu-jpl

This is about harvest not registry-mgr. Not sure if something is wrong in your environment or just putting messages in different PRs.

tloubrieu-jpl commented 1 month ago

Sorry @al-niessner, I was confused about what the PR was for. I will test that again, more appropriately.

tloubrieu-jpl commented 1 month ago

I was finally able to validate that new development by manual test on MCP Dev account.