search

NASA-PDS / harvest

Standalone Harvest client application providing the functionality for capturing and indexing product metadata into the PDS Registry system (https://github.com/nasa-pds/registry).
https://nasa-pds.github.io/registry
Other
4 stars 3 forks source link

As a user, I want to know when the file/label URL is not a URL #98

Open jordanpadams opened 2 years ago

jordanpadams commented 2 years ago

💪 Motivation

...so that I can more easily adapt my config to work for file paths.

📖 Additional Details

If your file path replacement does not work, it goes straight into the registry as a file path. We should catch this and immediately throw an ERROR and not ingest in the products. URLs must be required for all products ingested. We do not necessarily need to check the validity of the URL (we may need a tool to do this separately), but there should at least be an https: in the output URLs.

⚖️ Acceptance Criteria

Given When I perform Then I expect

⚙️ Engineering Details

acraugh commented 2 years ago

In terms of checking the validity of the URL, it might be a reasonable step to check the validity of the base URL in the configuration file. That will, at least, avoid universal typos. The assumption of paths aligning from the base URL down should then be pretty reliable.

jordanpadams commented 2 years ago

@acraugh 👍 sounds good. we will add that