Closed neese closed 1 year ago
@jordanpadams I tried to tag a release for this dictionary (Hyb2 1E00 1200) by following the steps at https://pds-data-dictionaries.github.io/development/ldd-release.html#tag-a-release-in-github, but it didn't trigger a GitHub Action. Has the procedure changed? Should I just post these files without a tagged release?
@c-suh looks like I updated the Github Action to only run when files in the src
directory change, not realizing I broke those instructions.
I updated the docs and manually triggered per the new procedure.
@c-suh @neese per above, merged those LDDs, and tag completed successfully: https://github.com/pds-data-dictionaries/ldd-hyb2/releases
@neese per this comment:
The dictionary was ready in GitHub for the December 2022 build deadline, but was not picked up for publication at that time. I think it may be because it is a mission dictionary, and only discipline dictionaries are included in the nominal build schedule releases?
that is correct. for mission LDDs, it is the responsibility of the steward to manually trigger the release. sorry for the confusion.
@c-suh @jordanpadams Thanks for the fast response. I am unsure what to do now. The instructions say I should now submit a PDS LDD Release request ticket, but I have already done so (this ticket). Do I submit another one, or will the release now happen without further action on my part?
Am I right in thinking now that all mission ldds should be released as an "off-nominal" release, in spite of the highlighted text in the instructions that say "Please try to avoid this [off-nominal release] whenever possible."?
The process of getting a mission ldd released is not documented properly, so both Kristina Lopez and I at SBN/PSI have wasted a lot of time. Could the documentation be updated to have a section just for mission ldds? Or at least mention and highlight at each stage if and how the process differs for mission ldds? The documentation now just refers to "ldd" and we followed the instructions but I think a lot or some of it was just for discipline ldds so what we did failed. Thanks if you can address this in the documentation.
@neese you are good on the ticket. @c-suh will take it from here.
the docs have been updated with a new Mission LDDs page. additionally, we are always open to any proposed updates. feel free to create a pull request at any time for the docs here: https://github.com/pds-data-dictionaries/PDS-Data-Dictionaries.github.io
@jordanpadams Thanks!
@neese this LDD has been posted to https://pds.nasa.gov/datastandards/dictionaries/index-missions.shtml#hyb2 !
Is the LDD IngestLDD in Github? Yes or no Yes
Has the LDD Namespace been registered in the Namespace Registry? Yes or no Yes
Latest LDD is in Github
NOTE: A code freeze is expected for this LDD repo as soon as this request is submitted in order to avoid collision with additional changes. Once this ticket has been closed, active development may resume. If the LDD to release is not in the repo, PDS Operations will upload those files to the repo.
Latest LDD is NOT in Github